Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

this.fire is not a function, only occurs when Google +1 button is on the page #17

Open
WillDonohoe opened this issue Sep 30, 2015 · 1 comment
Assignees

Comments

@WillDonohoe
Copy link

Hey guys,

A very unusual bug here. When attaching the google feeds element to the page, I get the following error:

Uncaught TypeError: this.fire is not a function - google-feeds.html:150.

This error only occurs when the Google +1 button is added to the page. See my JS bin example. It logs out the feed to the console. Try deleting the button markup, and notice the error no longer occurs.

The error points to this line: https://github.com/GoogleWebComponents/google-feeds/blob/master/google-feeds.html#L150

From a first glance, it looks like this is out of scope, and can be easily resolved by adding .bind(this) to the end of the enclosing method. But it's puzzling why this would be fired when a +1 button is added.

Can anybody share any insight?

Thanks

@ebidel
Copy link
Contributor

ebidel commented Sep 30, 2015

@addyosmani can you take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants