You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
A very unusual bug here. When attaching the google feeds element to the page, I get the following error:
Uncaught TypeError: this.fire is not a function - google-feeds.html:150.
This error only occurs when the Google +1 button is added to the page. See my JS bin example. It logs out the feed to the console. Try deleting the button markup, and notice the error no longer occurs.
From a first glance, it looks like this is out of scope, and can be easily resolved by adding .bind(this) to the end of the enclosing method. But it's puzzling why this would be fired when a +1 button is added.
Can anybody share any insight?
Thanks
The text was updated successfully, but these errors were encountered:
Hey guys,
A very unusual bug here. When attaching the google feeds element to the page, I get the following error:
Uncaught TypeError: this.fire is not a function - google-feeds.html:150.
This error only occurs when the Google +1 button is added to the page. See my JS bin example. It logs out the feed to the console. Try deleting the button markup, and notice the error no longer occurs.
The error points to this line: https://github.com/GoogleWebComponents/google-feeds/blob/master/google-feeds.html#L150
From a first glance, it looks like
this
is out of scope, and can be easily resolved by adding.bind(this)
to the end of the enclosing method. But it's puzzling why this would be fired when a +1 button is added.Can anybody share any insight?
Thanks
The text was updated successfully, but these errors were encountered: