Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add debounce to computeUrl to remove angular2 multiple api error #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrChoclate
Copy link

fix #67

It fixes the issue on my angular2 project.

@ebidel is this what you meant?:

the loading code can probably use a debouncer

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@MrChoclate
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

],

_debounceComputeUrl: function(mapsUrl, version, apiKey, clientId, language, signedIn) {
var _this = this;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need this

@ebidel
Copy link
Contributor

ebidel commented Aug 26, 2016

Thanks for the PR. I have some reservations about the approach. Namely, it will make all maps components 300ms slower. How short can you make the time before it no longer works?

@MrChoclate
Copy link
Author

It seems that wait=0 remove the error. It is way far beyond my expertise to understand why. So someone should check that it is correct.

Did I correctly understand your review?

@MrChoclate
Copy link
Author

My hypothesis is that Angular code is executed synchronously and is not letting the callback executed so that all the attributes of the Polymer element are properly set before the callback is executed.

Anyway, this PR won't slow anymore all maps components. But it will be great to have a comment explaining why it is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Maps API multiple times error with Angular 2
3 participants