-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race condition on google-client-loader #75
Comments
Pull request to workaround #76 |
Can you post a jsbin that repos the race condition. I'd like to understand whst caused the problem instead of hacking around it. |
I just create a jsbin https://jsbin.com/koquvi/9/edit?html,output but if works just fine because refer to polymer-cdn where https://github.com/Download/polymer-cdn/blob/master/lib/google-apis/google-client-loader.html use
instead ready hook in latest repo. If you change it to latest https://github.com/GoogleWebComponents/google-apis/blob/master/google-client-loader.html it will fail to race conditions. |
This was broken in #72 |
Actually I am having problems on it as well, especially on slow internet speeds. The quick hack on #76 did the trick. |
This happens for me every time. |
I tried setting interval in ready function like this |
I'm using the 2.x version of this element and have the same race condition. For me it happend because I have 10 times the google-client-loader element in my dom tree with different endpoints to connect to. The fix mentioned in #76 fixed my problems. |
I have created a pull request (#99) to solve this for the 2.x branch. |
It looks like the code in ready hook may not works properly and event js-api-load could be fired earlier than it is listned so the client is never loaded.
Tested on Google Chrome 52.0.2743.82 (64-bit)
The text was updated successfully, but these errors were encountered: