-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for headless login to firebase-auth.
- Loading branch information
Nicolas Garnier
committed
Jan 27, 2016
1 parent
09aa7d5
commit b6952e7
Showing
1 changed file
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6952e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signIn: function() {
this.$.authenticate.login();
},
this now gets an error, since i dont pass any params to the login function.
Error = row 228 : if (params.token) { << always null if login passed with no parameter
didnt happen before since this.redirect was false and this was not evaluated.
Am i required to pass a token now for Google as provider?
b6952e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah shoot. small bug. let me sent a PR to fix it...
b6952e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #107