Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm behavior when reordering pages #141

Closed
swissspidy opened this issue Jan 28, 2020 · 2 comments
Closed

Confirm behavior when reordering pages #141

swissspidy opened this issue Jan 28, 2020 · 2 comments
Assignees
@samitron7

Comments

@swissspidy
Copy link
Collaborator

As discussed at ampproject/amp-wp#4048 (review), when reordering pages (in the carousel or grid view), the reordered page is being set as the current page automatically.

We need to confirm whether this is desired behavior or not.

Relevant code section:

https://github.com/google/web-stories-wp/blob/7b1ed5c25b9bfd9b101217193dbcfe23d5849bb2/assets/src/edit-story/components/canvas/draggablePage.js#L52-L64
@swissspidy swissspidy mentioned this issue Jan 28, 2020
Merged
3 tasks
@jauyong
Copy link

jauyong commented Mar 6, 2020

pinging @samitron7 for an update on this.

@kmyram kmyram added this to the Sprint 25 milestone Mar 9, 2020
@swissspidy
Copy link
Collaborator Author

This was confirmed to be OK like this on Monday's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samitron7 samitron7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@swissspidy @kmyram @jauyong @samitron7