Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Structure: reduce redundancy when storing fonts #12261

Closed
swissspidy opened this issue Sep 8, 2022 · 0 comments · Fixed by #12625
Closed

Data Structure: reduce redundancy when storing fonts #12261

swissspidy opened this issue Sep 8, 2022 · 0 comments · Fixed by #12625
Assignees
Labels
Group: Fonts P2 Should do soon Package: Story Editor /packages/story-editor Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Sep 8, 2022

Feature Description

This is a follow-up to #12131.

Right now when adding 10 text elements all with the same font, there will be 10 font objects being stored, all with the same information. That's very redundant.

Instead of this, consider storing all existing fonts at the story level instead of on each element to reduce redundancy.

Add data migration.

Alternatives Considered

Additional Context

@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: Fonts P3 Nice to have Pod: Prometheus Package: Fonts /packages/fonts labels Sep 8, 2022
@swissspidy swissspidy added P2 Should do soon Package: Story Editor /packages/story-editor Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ and removed P3 Nice to have Pod: Prometheus Package: Fonts /packages/fonts labels Oct 2, 2022
@timarney timarney self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Fonts P2 Should do soon Package: Story Editor /packages/story-editor Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
3 participants