Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data migrations to remove lingering properties #12258

Closed
swissspidy opened this issue Sep 8, 2022 · 2 comments · Fixed by #12511
Closed

Add data migrations to remove lingering properties #12258

swissspidy opened this issue Sep 8, 2022 · 2 comments · Fixed by #12511
Assignees
@miina
Labels
Group: Migrations P2 Should do soon Package: Migration /packages/migration Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

This is a follow-up to #12131.

Despite previous migrations, there can be stories with lingering backgroundOverlay and fontWeight properties on elements. Let's add two migration functions that remove these.

See ac52897

Alternatives Considered

Additional Context
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature P2 Should do soon Pod: Prometheus Group: Migrations Package: Migration /packages/migration labels Sep 8, 2022
@swissspidy swissspidy mentioned this issue Sep 8, 2022
Merged
8 tasks
@miina
Copy link
Contributor

miina commented Oct 7, 2022

Hm, any idea where these come from?
fontWeight was removed in migration V17 and backgroundOverlay was converted into overlay in V26. Are these still added somewhere in code, or did it come from the templates?

@swissspidy
Copy link
Collaborator Author

Not sure, couldn‘t find anything in the code. Seems to be coming from the templates

@miina miina self-assigned this Oct 14, 2022
@miina miina mentioned this issue Oct 19, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miina miina

Labels
Group: Migrations P2 Should do soon Package: Migration /packages/migration Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove fontWeight and backgroundOverlay from element properties GoogleForCreators/web-stories-wp
2 participants
@swissspidy @miina