Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Convert media package #12087

Closed
swissspidy opened this issue Aug 9, 2022 · 0 comments · Fixed by #12127
Closed

TypeScript: Convert media package #12087

swissspidy opened this issue Aug 9, 2022 · 0 comments · Fixed by #12127
Assignees
@swissspidy
Labels
P2 Should do soon Package: Moveable /packages/moveable Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Aug 9, 2022 •
edited
Loading

There's already some POC here that can be leveraged.

The main benefit is the typing around the Resource type that we use all over the editor.

But there are also half-baked resource-like objects for things like background audio and captions that are worth creating proper types for.
@swissspidy swissspidy added P2 Should do soon Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP Package: Moveable /packages/moveable labels Aug 9, 2022
@swissspidy swissspidy mentioned this issue Aug 17, 2022
Merged
8 tasks
@swissspidy swissspidy self-assigned this Aug 22, 2022
@swissspidy swissspidy changed the title TypeScript: Convert media package TypeScript: Convert media package Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swissspidy swissspidy

Labels
P2 Should do soon Package: Moveable /packages/moveable Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeScript Conversion: media, units, react packages GoogleForCreators/web-stories-wp
1 participant
@swissspidy