Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sync #1709

Merged
merged 8 commits into from
Mar 1, 2019
Merged

Commits on Feb 28, 2019

  1. Fix bug in sync

    This PR fixes a bug in sync, in which desinations for synced files were
    being calculated incorrectly. For the hot-reload example, app.py was
    being synced to /src/app.py instead of /app.py, so it appeared as if
    sync wasn't actually working.
    
    To fix this issue, I fixed a bug in the intersect function to make sure
    destination calculation follows the Docker COPY command rules.
    
    For example, we had a unit test as follows:
    
    syncMap: **/**/*.js": "."
    file: dir1/dir2/node.js
    dst: /dir1/dir2/node.js
    
    when the destination should actually be /node.js based on Docker COPY
    command rules.
    Priya Wadhwa committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    b7ef0c7 View commit details
    Browse the repository at this point in the history
  2. Get filepath destination relative to image working dir

    Priya Wadhwa committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    49ef4ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d56c22 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. linting error

    Priya Wadhwa committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    67738fe View commit details
    Browse the repository at this point in the history
  2. Strip tags from image if digest is present

    since go-containerregistry can't currently handle both
    Priya Wadhwa committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    09c79d7 View commit details
    Browse the repository at this point in the history
  3. update file sync integration test

    Priya Wadhwa committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    65f5f3d View commit details
    Browse the repository at this point in the history
  4. linting error

    Priya Wadhwa committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    4503173 View commit details
    Browse the repository at this point in the history
  5. unit test error

    Priya Wadhwa committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    dc3131c View commit details
    Browse the repository at this point in the history