-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in sync #1709
Merged
Merged
Fix bug in sync #1709
Commits on Feb 28, 2019
-
This PR fixes a bug in sync, in which desinations for synced files were being calculated incorrectly. For the hot-reload example, app.py was being synced to /src/app.py instead of /app.py, so it appeared as if sync wasn't actually working. To fix this issue, I fixed a bug in the intersect function to make sure destination calculation follows the Docker COPY command rules. For example, we had a unit test as follows: syncMap: **/**/*.js": "." file: dir1/dir2/node.js dst: /dir1/dir2/node.js when the destination should actually be /node.js based on Docker COPY command rules.
Priya Wadhwa committedFeb 28, 2019 Configuration menu - View commit details
-
Copy full SHA for b7ef0c7 - Browse repository at this point
Copy the full SHA b7ef0c7View commit details -
Get filepath destination relative to image working dir
Priya Wadhwa committedFeb 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 49ef4ce - Browse repository at this point
Copy the full SHA 49ef4ceView commit details -
Get working dir from image and use as relative directory if necessary
Priya Wadhwa committedFeb 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 9d56c22 - Browse repository at this point
Copy the full SHA 9d56c22View commit details
Commits on Mar 1, 2019
-
Priya Wadhwa committed
Mar 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 67738fe - Browse repository at this point
Copy the full SHA 67738feView commit details -
Strip tags from image if digest is present
since go-containerregistry can't currently handle both
Priya Wadhwa committedMar 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 09c79d7 - Browse repository at this point
Copy the full SHA 09c79d7View commit details -
update file sync integration test
Priya Wadhwa committedMar 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 65f5f3d - Browse repository at this point
Copy the full SHA 65f5f3dView commit details -
Priya Wadhwa committed
Mar 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 4503173 - Browse repository at this point
Copy the full SHA 4503173View commit details -
Priya Wadhwa committed
Mar 1, 2019 Configuration menu - View commit details
-
Copy full SHA for dc3131c - Browse repository at this point
Copy the full SHA dc3131cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.