Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skaffold should rewrite imagePullPolicy when using a local cluster #6992

Open
briandealwis opened this issue Jan 5, 2022 · 3 comments · May be fixed by #9495
Open

Skaffold should rewrite imagePullPolicy when using a local cluster #6992

briandealwis opened this issue Jan 5, 2022 · 3 comments · May be fixed by #9495
Labels
area/deploy area/local bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/friction Issues causing user pain that do not have a workaround priority/p3 agreed that this would be good to have, but no one is available at the moment.
Milestone
Skaffold Bugbash ...

Comments

@briandealwis
Copy link
Member

When using a local cluster like minikube, where the built images are loaded directly into the cluster's container runtime, a user will encounter see a deployment failure should they specify an imagePullPolicy: Always. Skaffold should transform the manifests and either remove such pull-policies or possibly transform them to imagePullPolicy: Never.
@briandealwis briandealwis added area/deploy triage/discuss Items for discussion kind/friction Issues causing user pain that do not have a workaround area/local labels Jan 5, 2022
@tejal29 tejal29 added priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed triage/discuss Items for discussion labels Jan 10, 2022
@tejal29
Copy link
Member

tejal29 commented Jan 10, 2022 •
edited
Loading

I think it make complete sense. I would be ok to transform the manifests in memory since skaffold already parses these.

@tejal29 tejal29 mentioned this issue Apr 1, 2022
Closed
@ericzzzzzzz ericzzzzzzz self-assigned this Dec 7, 2022
@aaron-prindle aaron-prindle added the bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 label Dec 7, 2022
@aaron-prindle aaron-prindle added the help wanted We would love to have this done, but don't have the bandwidth, need help from contributors label Jan 4, 2023
@ericzzzzzzz ericzzzzzzz removed their assignment May 29, 2023
@th0ger
Copy link

th0ger commented Jun 19, 2024

Fully agree with the proposal.

A workaround for me is to use imagePullPolicy: IfNotPresent, since I use immutable image tags. (In which case imagePullPolicy can also be omitted, since IfNotPresent is default.)

@lucasrod16 lucasrod16 linked a pull request Aug 12, 2024 that will close this issue
Open
@lucasrod16
Copy link

Hi @briandealwis @tejal29,

I’ve submitted PR #9495 for this feature. Your feedback would be greatly appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/deploy area/local bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/friction Issues causing user pain that do not have a workaround priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
Skaffold Bugbash Q4 2022 - "Low Hangi...
Development

Successfully merging a pull request may close this issue.

feat: transform imagePullPolicy when using local cluster lucasrod16/skaffold
6 participants
@briandealwis @tejal29 @aaron-prindle @th0ger @lucasrod16 @ericzzzzzzz