Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using minikube image ls #5738

Open
medyagh opened this issue Apr 27, 2021 · 3 comments
Open

Consider using minikube image ls #5738

medyagh opened this issue Apr 27, 2021 · 3 comments
Labels
area/performance kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases

Comments

@medyagh
Copy link
Member

medyagh commented Apr 27, 2021

consider if it worth using minikube image ls to list the images in a cluster

@medyagh
Copy link
Member Author

medyagh commented Apr 27, 2021

cc: @aaron-prindle

@tejal29 tejal29 added area/performance kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases labels Apr 27, 2021
@tejal29 tejal29 changed the title consider using minikube image ls Consider using minikube image ls Apr 27, 2021
@aaron-prindle aaron-prindle self-assigned this May 9, 2021
@aaron-prindle aaron-prindle added this to the v1.25.0 milestone May 9, 2021
@tejal29 tejal29 modified the milestones: v1.25.0, v1.26.0 May 26, 2021
@aaron-prindle
Copy link
Contributor

aaron-prindle commented Jun 7, 2021

In discussions offline, it seemed that this would involve modifying findKnownImages or loadImages here:
https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/runner/v1/load_images.go#L93

I took a WIP inital stab here but see that just using minikube image ls here will be unused code atm:
https://github.com/GoogleContainerTools/skaffold/pull/5956/files

I see now that loadImages is only called currently for kind and k3d when they use their respective "load" commands:

kind:
https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/runner/v1/load_images.go#L38

k3d:
https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/runner/v1/load_images.go#L46

Minikube does not use it's load command currently so using minikube image ls would be unused code atm. Should this PR include/go-after a PR to use minikube image load? Perhaps I am missing the utility/code-locations this could be used? Thanks.

@tejal29 tejal29 added planning/Q4-21 Q4 2021 planning and removed planning/Q2-21 labels Jun 7, 2021
@tejal29 tejal29 removed this from the v1.26.0 milestone Jun 7, 2021
@aaron-prindle
Copy link
Contributor

Talked offline, this will go in after #5773 which @briandealwis is currently working on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

3 participants