Skip to content

Commit

Permalink
More review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Cornelius Weig <[email protected]>
  • Loading branch information
corneliusweig committed Jul 22, 2019
1 parent f5ee229 commit 0875984
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions integration/sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ func TestDevSyncAPITrigger(t *testing.T) {
ns, k8sclient, deleteNs := SetupNamespace(t)
defer deleteNs()

skaffold.Build().InDir("testdata/file-sync").InNs(ns.Name).RunOrFail(t)
skaffold.Build().InDir("testdata/file-sync").WithConfig("skaffold-manual.yaml").InNs(ns.Name).RunOrFail(t)

rpcAddr := randomPort()
client, shutdown := setupRPCClient(t, rpcAddr)
defer shutdown()

stop := skaffold.Dev("--auto-sync=false", "--rpc-port", rpcAddr).InDir("testdata/file-sync").InNs(ns.Name).RunBackground(t)
stop := skaffold.Dev("--auto-sync=false", "--rpc-port", rpcAddr).InDir("testdata/file-sync").WithConfig("skaffold-manual.yaml").InNs(ns.Name).RunBackground(t)
defer stop()

k8sclient.WaitForPodsReady("test-file-sync")
Expand Down
4 changes: 2 additions & 2 deletions pkg/skaffold/sync/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,14 @@ func inferredSyncItem(a *latest.Artifact, e filemon.Events, builds []build.Artif

syncMap, err := provider()
if err != nil {
return nil, errors.Wrapf(err, "infer syncmap for image %s", a.ImageName)
return nil, errors.Wrapf(err, "inferring syncmap for image %s", a.ImageName)
}

toCopy := make(map[string][]string)
for _, f := range append(e.Modified, e.Added...) {
relPath, err := filepath.Rel(a.Workspace, f)
if err != nil {
return nil, errors.Wrapf(err, "changed file %s can't be found relative to context %s", f, a.Workspace)
return nil, errors.Wrapf(err, "finding changed file %s relative to context %s", f, a.Workspace)
}

matches := false
Expand Down

0 comments on commit 0875984

Please sign in to comment.