set default HOME env properly #341
Conversation
pkg/commands/run.go
Outdated
| u = userObj.Username | ||
| } | ||
|
|
||
| return append(envs, fmt.Sprintf("%s=/home/%s", constants.HOME, u)) |
There was a problem hiding this comment.
I think that if the UID is set instead of username, the value of $HOME defaults to root /
I tried it out with this Dockerfile:
FROM ubuntu
USER 1000
CMD echo $HOME
and ran it:
$ docker run test
/
that's what seems like is happening. We still ignore Dockerfile_test_user_run in the integration tests, which is they didn't catch it.
I couldn't find any documentation to verify this unfortunately, it just says that HOME is determined by USER here 😞
There was a problem hiding this comment.
Yeah, I can verify that that is docker's behavior, silly as it is. Should we default to that? It seems like bad behavior since specifying username sets $HOME properly.
There was a problem hiding this comment.
Hmm yah it doesn't really make sense, but I guess we should probably try to mimic Docker as much as we can since it seems like people are running into issues with it.
There was a problem hiding this comment.
Any updates on this? I think copying Docker is probably the right thing to do by default.
Fixes #333