Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for the --destination flag #3274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dchaley
Copy link

@dchaley dchaley commented Aug 2, 2024

This PR intends to supersede #3042 . Given Nils's submission of the PR to public domain I will sign the CLA to get this documentation merged 😎 Much appreciated Nils!

Related to #217, #733

Description

(From Nils)
The flag is mostly self-explanatory, but its usage for multiple push was not documented anywhere.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • N/A Includes unit tests
  • N/A Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Copy link

google-cla bot commented Aug 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dchaley dchaley force-pushed the docs/multi-destination branch 2 times, most recently from fcb59c1 to cda72a3 Compare August 2, 2024 06:12
The flag is mostly self-explanatory, but its usage for multiple push
was not documented anywhere.

Related to GoogleContainerTools#217, GoogleContainerTools#733

Co-authored-by Nils, submitted to the public domain.
Nils Van Zuijlen <[email protected]>
See: GoogleContainerTools#3042
@dchaley
Copy link
Author

dchaley commented Aug 19, 2024

Hi @JeromeJu ! Wanted to bump this on your radar. (see also previous PR: #3042 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant