feat: migrate to bzlmod #1640
Merged
feat: migrate to bzlmod #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the node references are gone? |
no those went into |
|
oh I see, well maybe a name got mangled? : https://github.com/GoogleContainerTools/distroless/actions/runs/10311366649/job/28544819823?pr=1640#step:6:57 |
right, there was an issue in the extension, fixed now. |
|
🌳 🔄 Image Check This pull request has modified the following images: //base:static_root_amd64_debian12
//base:static_debug_root_amd64_debian12
//base:static_nonroot_arm64_debian12
//base:static_nonroot_arm_debian12
//base:static_debug_root_arm_debian12
//base:static_nonroot_s390x_debian12
//base:static_debug_root_ppc64le_debian12
//base:static_debug_nonroot_ppc64le_debian12
//base:static_root_arm_debian12
//base:base_root_amd64_debian12
//base:static_debug_root_arm64_debian12
//base:static_root_s390x_debian12
//base:base_root_arm64_debian12
//base:static_nonroot_amd64_debian12
//base:debug_nonroot_arm64_debian12
//base:debug_nonroot_amd64_debian12
//base:base_nonroot_amd64_debian12
//base:base_nonroot_arm64_debian12
//base:base_root_arm_debian12
//base:static_debug_nonroot_s390x_debian12
//base:debug_root_arm_debian12
//base:debug_root_amd64_debian12
//base:base_nonroot_s390x_debian12
//base:base_root_s390x_debian12
//base:static_nonroot_ppc64le_debian12
//base:static_debug_nonroot_arm64_debian12
//base:debug_nonroot_arm_debian12
//base:debug_root_ppc64le_debian12
//base:base_nonroot_ppc64le_debian12
//base:base_nonroot_arm_debian12
//base:debug_root_s390x_debian12
//base:base_nossl_root_amd64_debian12
//base:base_root_ppc64le_debian12
//base:base_nossl_root_arm64_debian12
//base:base_nossl_nonroot_arm64_debian12
//base:base_nossl_nonroot_amd64_debian12
//base:debug_nonroot_ppc64le_debian12
//base:base_nossl_root_arm_debian12
//base:static_root_ppc64le_debian12
//base:static_debug_root_s390x_debian12
//base:static_root_arm64_debian12
//base:base_nossl_debug_root_arm_debian12
//base:debug_nonroot_s390x_debian12
//base:base_nossl_debug_nonroot_amd64_debian12
//base:static_debug_nonroot_amd64_debian12
//base:base_nossl_debug_nonroot_arm64_debian12
//base:base_nossl_nonroot_s390x_debian12
//base:base_nossl_debug_root_amd64_debian12
//base:base_nossl_nonroot_ppc64le_debian12
//base:debug_root_arm64_debian12
//base:base_nossl_debug_nonroot_s390x_debian12
//base:base_nossl_debug_root_s390x_debian12
//cc:debug_nonroot_amd64_debian12
//base:static_debug_nonroot_arm_debian12
//cc:cc_nonroot_arm64_debian12
//cc:cc_nonroot_amd64_debian12
//base:base_nossl_root_s390x_debian12
//cc:cc_root_amd64_debian12
//cc:debug_root_amd64_debian12
//base:base_nossl_debug_nonroot_ppc64le_debian12
//cc:cc_root_s390x_debian12
//base:base_nossl_debug_nonroot_arm_debian12
//base:base_nossl_nonroot_arm_debian12
//cc:debug_root_arm64_debian12
//base:base_nossl_debug_root_ppc64le_debian12
//cc:debug_root_arm_debian12
//cc:debug_nonroot_arm_debian12
//base:base_nossl_debug_root_arm64_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:cc_nonroot_ppc64le_debian12
//python3:python3_root_amd64_debian12
//python3:python3_nonroot_amd64_debian12
//cc:cc_nonroot_s390x_debian12
//cc:debug_root_s390x_debian12
//base:base_nossl_root_ppc64le_debian12
//cc:cc_root_arm64_debian12
//cc:cc_nonroot_arm_debian12
//cc:cc_root_ppc64le_debian12
//python3:debug_nonroot_amd64_debian12
//python3:debug_root_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//cc:debug_root_ppc64le_debian12
//nodejs:nodejs18_debug_nonroot_amd64_debian12
//cc:debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//python3:debug_root_amd64_debian12
//nodejs:nodejs18_root_amd64_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//cc:cc_root_arm_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian12
//nodejs:nodejs18_nonroot_amd64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//python3:python3_root_arm64_debian12
//nodejs:nodejs18_debug_root_arm64_debian12
//nodejs:nodejs18_nonroot_arm_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//nodejs:nodejs18_nonroot_arm64_debian12
//nodejs:nodejs18_debug_root_amd64_debian12
//nodejs:nodejs18_debug_root_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs18_root_arm_debian12
//nodejs:nodejs18_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs18_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs18_debug_root_s390x_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs18_debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs18_debug_nonroot_s390x_debian12
//nodejs:nodejs18_root_arm64_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs18_debug_root_ppc64le_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs18_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs18_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs18_debug_nonroot_ppc64le_debian12
//java:java_base_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//java:java_base_nonroot_arm64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//java:java_base_nonroot_s390x_debian12
//java:java_base_debug_nonroot_arm64_debian12
//java:java_base_nonroot_amd64_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//java:java_base_root_amd64_debian12
//nodejs:nodejs22_root_s390x_debian12
//java:java_base_root_ppc64le_debian12
//java:java_base_debug_root_ppc64le_debian12
//nodejs:nodejs18_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//java:java17_debug_root_amd64_debian12
//java:java_base_root_arm64_debian12
//java:java_base_debug_root_s390x_debian12
//java:java_base_debug_nonroot_amd64_debian12
//java:java17_root_amd64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//java:java17_root_arm64_debian12
//java:java_base_root_s390x_debian12
//java:java_base_nonroot_ppc64le_debian12
//java:java17_root_s390x_debian12
//java:java17_root_ppc64le_debian12
//java:java_base_debug_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//java:java_base_debug_nonroot_s390x_debian12
//java:java17_nonroot_amd64_debian12
//java:java17_debug_root_arm64_debian12
//java:java17_debug_nonroot_ppc64le_debian12
//java:java_base_debug_nonroot_ppc64le_debian12
//java:java17_debug_nonroot_amd64_debian12
//java:java17_nonroot_s390x_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_nonroot_ppc64le_debian12
//java:java17_nonroot_ppc64le_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java17_debug_root_s390x_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java17_debug_nonroot_s390x_debian12
//java:java17_debug_nonroot_arm64_debian12
//java:java21_root_arm64_debian12
//java:java21_root_amd64_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//java:java17_nonroot_arm64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java17_debug_root_ppc64le_debian12You can check the details in the report here |
|
@loosebazooka this is ready now. |
|
cc @alexeagle as he promised to review. |
|
oh shoot, I merged something in that probs needs a rebase+fix |
| @@ -1,9 +1,99 @@ | |||
| "repositories for nodejs" | |||
| "node" | |||
There was a problem hiding this comment.
@omBratteng fyi, if you are updating node packages they are now in private/extensions/node.bzl
🙊 |
|
@thesayyn needs a rebase? |
|
There are some assumptions in this implementation that make it hard to import this in a downstream module. Will that be supported later? |
I think fundamentally we dont want anyone importing distroless as a downstream module. If you wish to build distroless style images -- rules_distroless is what you need? What exactly is your usecase? Are there pieces in here that need to move into rules_distroless? |
finally got around to rebase. it should be ready now. i can't confirm |
|
I can update the script for Java later |
scripts/update_java_archives.sh
Outdated
Comment on lines
46
to
48
| exit 1 | ||
|
|
||
|
|
There was a problem hiding this comment.
this looks like a debug exit that was left in here?
|
looks like the image diffs (non-java) are mostly just related to: GoogleContainerTools/rules_distroless#71 |
|
java versions need to be sync'd, there was an update here: #1649 |
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating to bzlmod, needs GoogleContainerTools/rules_distroless#70 first.