Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track a 'more' metric for the Updater #1101

Open
michelle192837 opened this issue Dec 19, 2022 · 3 comments · May be fixed by #1139
Open

Track a 'more' metric for the Updater #1101

michelle192837 opened this issue Dec 19, 2022 · 3 comments · May be fixed by #1139
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michelle192837
Copy link
Collaborator

The Updater logs when it has more work to do after updating a test group (with 'more = true' in the log line), but it'd be nice to have a metric that allows us to track if there are spikes in groups that don't update, or a consistent line of groups that can't catch up on repeated updates. (This is expected in small numbers because some group updates, especially for new groups, take a long time, but it's a bad sign if this climbs or stays high).

@michelle192837 michelle192837 added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 19, 2022
@moki1202
Copy link
Contributor

@michelle192837 Can this be solved by making a map and every time the update function returns an error, we log the results in our map. Plus we can include a counter to it.

@michelle192837
Copy link
Collaborator Author

We actually have a standard metrics interface use throughout components that can be used for this! We just need to add that to the list of metrics tracked, and increment at the right time.

More specifically:

@moki1202
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants