fix: set maxInboundMetadataSize in pubsub

[JoeWang1127]

Fix: #2785

[JoeWang1127]

Native tests against storage sample failed:

Error: Classes that should be initialized at run time got initialized during image building:
 org.apache.commons.logging.LogFactory was unintentionally initialized at build time. To see why org.apache.commons.logging.LogFactory got initialized use --trace-class-initialization=org.apache.commons.logging.LogFactory
org.apache.commons.logging.LogFactoryService was unintentionally initialized at build time. To see why org.apache.commons.logging.LogFactoryService got initialized use --trace-class-initialization=org.apache.commons.logging.LogFactoryService
To see how the classes got initialized, use --trace-class-initialization=org.apache.commons.logging.LogFactory,org.apache.commons.logging.LogFactoryService

This is irrelevant to this PR.

[zhumin8]

Do you mind adding a comment citing the pubsub client library default?
Also, do you think this default behavior is worth mentioning somewhere in the documentation?

[JoeWang1127]

Also, do you think this default behavior is worth mentioning somewhere in the documentation?

Do you mean in SCGCP docs?

[zhumin8]

Do you mean in SCGCP docs?

Yes, I am referring to SCGCP docs. In light of "secure by defaults", although we are hardcoding in this case, IMO it probably still worth explicitly spell out that we are following PubSub client library defaults for these settings.

Another question, should we also set "maxInboundMessageSize" as client library does here? And what about publisherTransportChannelProvider setting? At a glance, it looks like SCGCP is not keeping consistent with client library defaults here?

[mpeddada1]

Is it possible to reference the default variable here instead of hardcoding the default value? Just so that we are aligned with the default in the client in case it changes in the future.

[JoeWang1127]

The default value is a private variable that can't be referenced (source).

[mpeddada1]

Thanks for checking, That is a little unfortunate that it can't be referenced at the moment. It might be worth creating a ticket in the client repo (similar to googleapis/java-pubsub#373)

[JoeWang1127]

I think the builder is autogenerated by the generator: https://github.com/googleapis/java-pubsub/blob/main/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SubscriptionAdminSettings.java#L246 and https://github.com/googleapis/java-pubsub/blob/main/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/stub/SubscriberStubSettings.java#L425

[JoeWang1127]

Another question, should we also set "maxInboundMessageSize" as client library does here?

maxInboundMessageSize is set here.

And what about publisherTransportChannelProvider setting? At a glance, it looks like SCGCP is not keeping consistent with client library defaults here?

I think publisherTransportChannelProvider should be another issue.

[mpeddada1]

Also, do you think this default behavior is worth mentioning somewhere in the documentation?

+1 how about we document this in https://googlecloudplatform.github.io/spring-cloud-gcp/reference/html/index.html#publishersubscriber-configuration?

[JoeWang1127]

+1 how about we document this in https://googlecloudplatform.github.io/spring-cloud-gcp/reference/html/index.html#publishersubscriber-configuration?

I didn't add this property in GcpPubSubProperties and I don't see TransportChannelProvider can be custom configured in the existing pubsub properties.

I think we shouldn't surface this property in the doc, what do you think?

[mpeddada1]

+1 how about we document this in https://googlecloudplatform.github.io/spring-cloud-gcp/reference/html/index.html#publishersubscriber-configuration?

I didn't add this property in GcpPubSubProperties and I don't see TransportChannelProvider can be custom configured in the existing pubsub properties.

I think we shouldn't surface this property in the doc, what do you think?

Agreed that this particular property can't be configured so adding it as part of the configurations table might be confusing but I think users can still customize the subscriberTransportChannelProvider by providing their own bean. It might still be worth adding "Note" section in the documentation which mentions this default value? As an example, we have a note that mentions the default thread names we use:

By default, subscription-specific threads are named after fully-qualified subscription name, ex: gcp-pubsub-subscriber-projects/project-id/subscriptions/subscription-name. This can be customized, by registering a SelectiveSchedulerThreadNameProvider bean.

[JoeWang1127]

It might still be worth adding "Note" section in the documentation which mentions this default value

Added a note in the pubsub doc.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud