Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changes boilerplate to LLC #4201

Merged
merged 5 commits into from
Jun 29, 2020
Merged

chore: changes boilerplate to LLC #4201

merged 5 commits into from
Jun 29, 2020

Conversation

telpirion
Copy link
Contributor

Small change: switches to "Google, LLC" in boilerplate.

No region tags are affected.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2020
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2020
@telpirion telpirion requested a review from leahecole June 29, 2020 22:05
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass 😜

@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 29, 2020

@telpirion @leahecole

Actually, you should not change this.

@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 29, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 29, 2020

Ah it depends on when the file is added and whether Google was Inc or LLC at that time.

So go ahead if you're sure Google was already an LLC when the file is added :)

@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 29, 2020
@telpirion
Copy link
Contributor Author

No worries ... I was using this as a demo of the PR process for a new team member.

It looks like Google became an LLC in 2015/2016. I'll defer to you folks as to whether we should change this comment (or not).

I'll find another example for this CL.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 29, 2020

@telpirion Then this looks good.

@telpirion telpirion marked this pull request as ready for review June 29, 2020 23:04
@telpirion telpirion requested review from sirtorry and a team as code owners June 29, 2020 23:04
@telpirion telpirion merged commit a85c4f0 into master Jun 29, 2020
@telpirion telpirion deleted the video-comments-update branch June 29, 2020 23:22
danoscarmike pushed a commit to danoscarmike/python-videointelligence that referenced this pull request Sep 28, 2020
…n-docs-samples#4201)

* chore: changes boilerplate to LLC

* fix: Better style for comment
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…n-docs-samples#4201)

* chore: changes boilerplate to LLC

* fix: Better style for comment
dizcology pushed a commit that referenced this pull request Sep 11, 2023
* chore: changes boilerplate to LLC

* fix: Better style for comment
leahecole pushed a commit that referenced this pull request Sep 15, 2023
* chore: changes boilerplate to LLC

* fix: Better style for comment
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…n-docs-samples#4201)

* chore: changes boilerplate to LLC

* fix: Better style for comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants