Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 request is not filtered #11

Closed
kintel opened this issue Mar 18, 2020 · 3 comments
Closed

OAuth2 request is not filtered #11

kintel opened this issue Mar 18, 2020 · 3 comments

Comments

@kintel
Copy link

kintel commented Mar 18, 2020

I've written a minimal node.js client using NodeTracerProvider.
A simple test run uncovered that the OAuth2 request is not filtered, and shows up as POST /oauth2/v4/token in the Cloud Trace backend.

I can dig around a bit myself, but opening this in case someone already knows why.

Note: This works as expected using the OpenCensus agent with pretty much the same client implementation.

@kintel kintel changed the title OAuth2 request id not filtered OAuth2 request is not filtered Mar 18, 2020
@mayurkale22
Copy link
Contributor

Thanks for reporting this! If you are feeling motivated, maybe you can attempt to write solution and open a PR.

@kintel
Copy link
Author

kintel commented Mar 20, 2020

I'll keep it on my list. Writing a solution is likely the easy part. Getting integration tests set up for this may prove to be significantly more effort : /

@TigerHe7 TigerHe7 assigned TigerHe7 and unassigned TigerHe7 Jul 8, 2020
@aabmass
Copy link
Contributor

aabmass commented Feb 1, 2021

I am no longer seeing this issue. Instrumentation is now suppressed in the BatchSpanProcessor and SimpleSpanProcessor from open-telemetry/opentelemetry-js#1344

@aabmass aabmass closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants