Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading name and description for reconcile-interval-seconds flag #87

Open
bcheung opened this issue Jul 28, 2020 · 0 comments
Open

Comments

@bcheung
Copy link
Contributor

bcheung commented Jul 28, 2020

This may be a breaking change, so fix this on the next major release. The reconcile-interval-seconds flag has a misleading name and description for time.Duration type, remove "seconds" from flag name and description and update netd.yaml as well.
Note: #86 fixes the default value for the reconcile-interval-seconds flag.

fs.DurationVar(&nc.ReconcileIntervalSeconds, "reconcile-interval-seconds", 10,
"Reconcile interval in seconds.")

netd/netd.yaml

Line 100 in fef8459

reconcile_interval_seconds: "60s"

netd/netd.yaml

Line 204 in fef8459

- --reconcile-interval-seconds=$(RECONCILE_INTERVAL_SECONDS)

netd/netd.yaml

Line 213 in fef8459

- name: RECONCILE_INTERVAL_SECONDS

netd/netd.yaml

Line 217 in fef8459

key: reconcile_interval_seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant