Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Implement a clean way to get the deployed app URL #93

Open
meltsufin opened this issue Dec 13, 2016 · 3 comments
Open

[Testing] Implement a clean way to get the deployed app URL #93

meltsufin opened this issue Dec 13, 2016 · 3 comments

Comments

@meltsufin
Copy link
Member

No description provided.

@jmcc0nn3ll
Copy link
Contributor

This would allow us to do away with the split IntegrationTest setup, LocalIntegrationTest/RemoteIntegrationTest. Currently the only fundamental difference between the two is this URI, localhost: for local and the remote URI combining service id, project id and version.

Now there will likely be differences in tests soon we are currently able to express now, but a cleaner approach down the road might be to use test scoped annotations instead of the <includes/excludes> in the pom.xml.

tl;dr easy access to the URI means we can re-evaluate some testing structure

@joakime
Copy link
Contributor

joakime commented Dec 13, 2016

This seems similar to the enhancement request at GoogleCloudPlatform/app-maven-plugin/issues/86

@jmcc0nn3ll
Copy link
Contributor

That's the one I was looking for, thanks @joakime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants