Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make substitutions in app.yaml for local/remote testing on a per-test basis #110

Open
janbartel opened this issue Dec 23, 2016 · 2 comments
Assignees

Comments

@janbartel
Copy link
Contributor

For testing sessions, I need to be able to put an env var into app.yaml (eg SESSIONS: 'datastore'). This env var shouldn't be there when local tests are run (unless the local docker execution is set up with the correct gcloud project properties etc). This substitution should really only be done when a specific test - eg RemoteSessionIntegerationTest - is run. I can't see how to accomplish this with the existing structure. Is there any way to accommodate this?

@meltsufin
Copy link
Member

@janbartel The maven property substitutions seems to work in app.yaml at a profile level if you just specify the properties under the corresponding profile. However, it sounds like you want to have properties on a per test basis. Is that correct?
In that case, it might be better to just create more test apps specifically for testing various session configurations.

@jmcc0nn3ll
Copy link
Contributor

As @meltsufin notes, unless a configured container is meant to be deployed with different session stores dynamically then this datastore test case should be bundled up in a test-session-datastore(?) artifact and execute accordingly.

Then the actual test method should be annotated with @RemoteOnly, at least until there is a reasonable configuration that allows containers deployed other places (locally, etc) to leverage that session store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants