-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add text generation samples - part 3 #10156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(genai): add text generation samples - part 3 #10156
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request expands the GenAI Java samples by adding three new examples. These samples demonstrate various text generation capabilities, including standard and streaming chat interactions, and the ability to transcribe audio from Google Cloud Storage into text. The goal is to provide developers with clear, runnable code to integrate these features into their applications.
Highlights
- New Chat Session Sample: Introduces TextGenerationChatWithText.java to demonstrate creating and interacting with a new chat session for text generation.
- New Chat Stream Session Sample: Introduces TextGenerationChatStreamWithText.java to showcase streaming responses from a chat session.
- New Audio Transcript Sample: Introduces TextGenerationTranscriptWithGcsAudio.java to illustrate generating text transcripts from audio input stored in Google Cloud Storage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces three new text generation samples for the GenAI SDK, demonstrating chat streams, chat sessions with system instructions, and audio transcription from GCS. The additions are accompanied by corresponding integration tests. The new samples are clear and useful. However, I've identified a potential issue in the TextGenerationChatWithText sample where chained calls to systemInstruction would lead to the first instruction being overwritten. I've provided a suggestion to correct this by using the list-based overload of the method.
genai/snippets/src/main/java/genai/textgeneration/TextGenerationChatWithText.java
Outdated
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationChatStreamWithText.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationChatWithText.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationTranscriptWithGcsAudio.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationChatWithText.java
Outdated
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationChatWithText.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationTranscriptWithGcsAudio.java
Outdated
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/textgeneration/TextGenerationTranscriptWithGcsAudio.java
Show resolved
Hide resolved
msampathkumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need to fix the branch file conflicts.
Description
Add new text generation samples (3):
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only