Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen(videointelligence)!: drop support for V1beta1 version of the API #9426

Merged
merged 2 commits into from
Oct 8, 2019
Merged

codegen(videointelligence)!: drop support for V1beta1 version of the API #9426

merged 2 commits into from
Oct 8, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 8, 2019

Closes #9425

@tseaver tseaver added api: videointelligence Issues related to the Video Intelligence API API. codegen labels Oct 8, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@tseaver tseaver mentioned this pull request Oct 8, 2019
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Oct 8, 2019

@busunkim96 If the change to googleapis dropping v1beta1 is inadvertent, then we should just close this PR.

@busunkim96
Copy link
Contributor

Luke just sent a message in the team chat saying he was reverting something - I will revisit this later in the day.

busunkim96
busunkim96 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the proto deletion was intentional. This endpoint has been turned off.

@tseaver tseaver merged commit 59d967e into googleapis:master Oct 8, 2019
@tseaver tseaver deleted the 9425-videointelligence-drop-v1beta1 branch October 8, 2019 17:31
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
codegen(videointelligence)!: drop support for V1beta1 version of th…
40d7c98 
…e API (#9426)

Closes #9425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for videointelligence
3 participants
@tseaver @busunkim96 @googlebot