feat: AbortController to signal request timeouts #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrobertson
force-pushed
the
zombie-timeouts
branch
from
0811780 to
2a8d139
Compare
matthewrobertson
changed the title
matthewrobertson
force-pushed
the
zombie-timeouts
branch
from
2a8d139 to
30af4a4
Compare
HKWinterhalter
approved these changes
Apr 25, 2024
Contributor
HKWinterhalter
left a comment
HKWinterhalter
left a comment
There was a problem hiding this comment.
Looks good, thanks for figuring this out
matthewrobertson
force-pushed
the
zombie-timeouts
branch
5 times, most recently
from
c937173 to
8d63104
Compare
This commit adds a nodejs AbortController to the HTTP request object that is used to signal cancellation for a function execution in the event of a timeout or client disconnect.
matthewrobertson
force-pushed
the
zombie-timeouts
branch
from
8d63104 to
e7c4400
Compare
This was referenced May 21, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a nodejs AbortController to the HTTP request object that is used to signal cancellation for a function execution in the event of a timeout or client disconnect.