feat: add instance dialing to health check #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
changed the title
enocom
reviewed
Aug 6, 2021
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
Generally looking pretty good. A number of comments below.
* Add function to client that exposes instances list * Add Dial op to proxy readiness criteria * Close each connection after dialing * Add error path tests for dialing in readiness test * Add health check flags to README * Dial all specified instances in non-fuse modes * Remove InstanceGetter * Change tests so they work with new NewServer * Fix flag * Add sample yaml config w/ probes * Add fields for each probe * Validate instances in fuse mode * Add end to end tests for successful dialing
enocom
reviewed
Aug 9, 2021
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
There are a few accidental additions that need to be removed.
enocom
approved these changes
Aug 11, 2021
kurtisvg
suggested changes
Aug 12, 2021
kurtisvg
approved these changes
Aug 12, 2021
enocom
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Mona Zhang [email protected]