Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Guava dependency missing from jar-with-dependencies #1861

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Tasssadar
Copy link
Contributor

Doing the solution suggested in #1858, but for all the jdbc drivers, as they all seem to have the same problem.

It compiles correctly, test also compile but I'm unable to run them locally.

Fixes #1858

Copy link
Collaborator

@ttosta-google ttosta-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttosta-google ttosta-google merged commit fd05682 into GoogleCloudPlatform:main Feb 22, 2024
21 checks passed
@Tasssadar Tasssadar deleted the fix_guava_dep branch February 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fat "jar-with-dependencies" PostgreSQL JDBC driver is missing Guava dependency inside
2 participants