Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Public Image Instead of Building One #181

Open
jamesward opened this issue Jun 16, 2020 · 2 comments
Open

Use Public Image Instead of Building One #181

jamesward opened this issue Jun 16, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jamesward
Copy link
Contributor

If a project publishes a public container image then maybe the button should allow the skipping the build and just using the existing image. Via app.json like:

{
    "build": {
        "skip": false
    },
    "override": {
        "image": "gcr.io/cloudrun/hello"
    }
}

Not sure if this is a good idea or not.

@jamesward jamesward added the enhancement New feature or request label Jun 16, 2020
@ahmetb
Copy link
Contributor

ahmetb commented Jun 16, 2020

This basically makes the project an alternative to deploying directly from Cloud Run console. Similarly, broadens the focus from "deploy repos" to "deploy images or repos".

@jamesward
Copy link
Contributor Author

Yeah, maybe if https://console.cloud.google.com/run/create had a way to specify some default params (image, service name, allow-unauthenticated, etc) then that'd be a better way to go. Still would be missing env var handling though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants