Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant inference in BuildSQLAgent? #42

Open
rafi-rr opened this issue Sep 4, 2024 · 0 comments
Open

Redundant inference in BuildSQLAgent? #42

rafi-rr opened this issue Sep 4, 2024 · 0 comments

Comments

@rafi-rr
Copy link
Contributor

rafi-rr commented Sep 4, 2024

I was going over the inferences that the code performs and my understanding is that there's no point in performing the send_message call below if there was no previous question/SQL.
I can suggest a simple PR to avoid if these values are None.
What do you think?

response = chat_session.send_message(build_context_prompt, stream=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant