Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browsingContext.navigationStarted the URL is always an empty string #2277

Open
OrKoN opened this issue Jun 4, 2024 · 2 comments
Open

browsingContext.navigationStarted the URL is always an empty string #2277

OrKoN opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 4, 2024

See https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/src/bidiMapper/modules/context/BrowsingContextImpl.ts#L376

Is it intended? it causes failures in Puppeteer.
@OrKoN OrKoN added the bug Something isn't working label Jun 4, 2024
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 4, 2024

Firefox sends the URL where the context is being navigated to, which I believe might not be what Puppeteer expects either.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 7, 2024

I have changed Puppeteer implementation to not rely on the navigationStarted. The issue is still worth fixing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OrKoN