Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Convert web feature consumer from service to job #474

Open
jcscottiii opened this issue Jul 2, 2024 · 0 comments
Open

[ENHANCEMENT] Convert web feature consumer from service to job #474

jcscottiii opened this issue Jul 2, 2024 · 0 comments
Labels
enhancement New feature or request go Pull requests that update Go code max_estimate:1day Unblocked work that will take a day or less tech-debt Issues that reduce the technical debt of the project terraform Pull requests that update Terraform code

Comments

@jcscottiii
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, the web feature consumer ingestion step is a http service that starts when it receives a http request. This was originally setup because we leverage Google Cloud Workflows and I thought that was the only way to do custom steps. However, it turns out that we can make the step be a cloud run job instead.

Describe the solution you'd like

  • Make the web feature consumer step an executable like the wpt consumer step
    • Remove the http code from web feature consumer
  • Modify the terrarform to deploy a cloud run job instead of a cloud run service.
  • Remove the OpenAPI spec for the web feature consume step
    • Remove the generation of an OpenAPI code in the Makefile
    • Remove all util code that uses the client in util/cmd/local_web_feature_workflow/main.go
  • Remove the skaffold.yaml for the web feature consumer
    • Remove the pod.yaml for the web feature consumer and make a job.yaml (look at the ones for BCD and WPT)
  • Modify the Makefile to use the new job.yaml and remove the call to util/cmd/local_web_feature_workflow/main.go
@jcscottiii jcscottiii added enhancement New feature or request go Pull requests that update Go code tech-debt Issues that reduce the technical debt of the project max_estimate:1day Unblocked work that will take a day or less terraform Pull requests that update Terraform code labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code max_estimate:1day Unblocked work that will take a day or less tech-debt Issues that reduce the technical debt of the project terraform Pull requests that update Terraform code
Projects
Status: No status
Development

No branches or pull requests

1 participant