Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

fix: set navigateFallbackWhitelist from config #227

Merged
merged 1 commit into from
Dec 14, 2016
Merged

fix: set navigateFallbackWhitelist from config #227

merged 1 commit into from
Dec 14, 2016

Conversation

kevinbuhmann
Copy link
Contributor

@kevinbuhmann kevinbuhmann commented Dec 13, 2016

We encountered an issue where the fallback white list would always be written as an empty array no matter what the config file specified. This change fixes that.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kevinbuhmann
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick
Copy link
Contributor

Thanks!

@jeffposnick jeffposnick merged commit 28136db into GoogleChromeLabs:master Dec 14, 2016
@kevinbuhmann
Copy link
Contributor Author

Thanks for merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants