This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Make the SW more resilient to caches being manually cleared. #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface @addyosmani
Fixes #185
If the user manually clears the contents of Cache Storage, but doesn't unregister the SW, then
sw-precache
would get into a bad state, where it didn't properly fall back to the network. This fixes that bug.(Deep down, I knew that
cache.match()
resolves withundefined
rather than rejecting when it doesn't match, but it's so easy to forget...)