diff --git a/lighthouse-core/audits/errors-in-console.js b/lighthouse-core/audits/errors-in-console.js index 6ae4d4bcdd51..8b02ac15d93f 100644 --- a/lighthouse-core/audits/errors-in-console.js +++ b/lighthouse-core/audits/errors-in-console.js @@ -45,10 +45,10 @@ class ErrorLogs extends Audit { /** @return {AuditOptions} */ static defaultOptions() { - return {}; + // Any failed network requests with error messsage aren't actionable + return {ignoredPatterns: ['ERR_BLOCKED_BY_CLIENT.Inspector']}; } - /** * @template {{description: string | undefined}} T * @param {Array} items diff --git a/lighthouse-core/test/audits/errors-in-console-test.js b/lighthouse-core/test/audits/errors-in-console-test.js index 70312af89752..3064f7cf0679 100644 --- a/lighthouse-core/test/audits/errors-in-console-test.js +++ b/lighthouse-core/test/audits/errors-in-console-test.js @@ -224,4 +224,21 @@ describe('ConsoleMessages error logs audit', () => { expect(result.details.items).toHaveLength(0); }); }); + + describe('defaultOptions', () => { + // See https://github.com/GoogleChrome/lighthouse/issues/10198 + it('filters out blocked_by_client.inspector messages by default', () => { + const auditResult = ErrorLogsAudit.audit({ + ConsoleMessages: [{ + 'source': 'exception', + 'level': 'error', + 'timestamp': 1506535813608.003, + 'url': 'https://www.facebook.com/tr/', + 'text': 'Failed to load resource: net::ERR_BLOCKED_BY_CLIENT.Inspector', + }], + }, {options: ErrorLogsAudit.defaultOptions()}); + assert.equal(auditResult.score, 1); + assert.equal(auditResult.details.items.length, 0); + }); + }); });