Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

getAuthToken and oauth2 manifest documentation should mention failure modes #737

Closed
ericlaw1979 opened this issue May 5, 2021 · 2 comments
Labels
bug Something on the site is broken! content extensions Issues related to extensions documentation.

Comments

@ericlaw1979
Copy link
Contributor

ericlaw1979 commented May 5, 2021

The documentation for the chrome.identity APIs does not mention that they will fail when an admin has disabled the BrowserSignin policy or (Chromium 87+) when the APIs are called from Chromium or another non-Google Chrome browser.

Some discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=1205882#c5

Chrome Dev points to this post which includes some context and a prototype polyfill: https://groups.google.com/a/chromium.org/g/embedder-dev/c/tGCJ3QNVzYE

@ericlaw1979 ericlaw1979 added the bug Something on the site is broken! label May 5, 2021
@dotproto dotproto added the extensions Issues related to extensions documentation. label May 5, 2021
@dotproto
Copy link
Contributor

dotproto commented May 5, 2021

I agree that we should document the interaction with BrowserSignin. Thanks for calling out that chrome.identity fails in Chromium. I was not aware of that divergence and agree that we should document it. If you have any observations or guidance you can share here, it would be very welcome.

More broadly, I don't think we can or should cover non-Chrome Chromium based browsers. Our global namespace, documentation site URL, and web store name all highlight the Chrome-centric nature of the platform being provided. Since Chromium is a Google project, I think documenting divergence between Chrome and Chromium is within our charge, but we do not necessarily have insight into how other Chromium based browsers modify the extensions platform.

@devnook devnook added the content label Sep 5, 2022
@dstmarthe
Copy link
Collaborator

Thanks for raising this. We’ve moved to a new platform and so we’ll fix this over there. I’ve moved the issue to our new tracker and you can see it at:
https://issuetracker.google.com/issues/324323521

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something on the site is broken! content extensions Issues related to extensions documentation.
Projects
None yet
Development

No branches or pull requests

4 participants