This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Add configurable blacklist phrases and stop words to LinkWithUnclearPurpose #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ewinslow PTAL? |
|
@slauriat PTAL? |
added 2 commits
August 5, 2014 07:51
| @@ -148,4 +148,52 @@ test("Unsupported Rules Warning not shown if with console API on configuration s | |||
| equal(0, __warnings.length); | |||
| }); | |||
|
|
|||
| test("Configure LinkWithUnclearPurpose", function() { | |||
There was a problem hiding this comment.
Can we split this into several more specific/descriptive tests?
|
@ewinslow Ready for another look, PTAL. |
|
LGTM. The extra comments help a lot. Thanks! |
alice
pushed a commit
that referenced
this pull request
Aug 6, 2014
Add configurable blacklist phrases and stop words to LinkWithUnclearPurpose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.