Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

adds selectors to the Audit results #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philschatz
Copy link
Contributor

@philschatz philschatz commented Sep 28, 2016

This adds an additional field to the Audit results object which provides an array of selectors that were found. I added it as an additional field to maintain backwards-compatibility with previous versions.

Some use-cases for adding selectors:

Questions

  1. Since getQuerySelectorText(element) does not always generate a valid selector, should it be configured in the AuditConfig via something like config.includeSelectors = true?
  2. Oh dear, it looks like Google forgot that I signed the CLA; how should I proceed?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants