Add .matches() as default choice for browserUtils.matchSelector #189
Conversation
Formerly known as matchesSelector(), with many vendor prefixes as seen in this function. I'm using ADT in a jsdom environment, which doesn't support any vendor-prefixed variations of this function. http://caniuse.com/#feat=matchesselector
| @@ -15,6 +15,7 @@ | |||
| goog.provide('axs.browserUtils'); | |||
|
|
|||
| /** | |||
| * Use Webkit matcher when matches() is not supported. | |||
There was a problem hiding this comment.
Should this read "Use Webkit matcher when matches() is supported."?
There was a problem hiding this comment.
Ah, I see you were just adding missing documentation, this makes sense to me now.
There was a problem hiding this comment.
Yeah, tried to follow the pattern we had going on here
|
It'd be nice to find a way to unit test this. LGTM unless that's a typo in the docs. |
Add .matches() as default choice for browserUtils.matchSelector
|
Thanks! |
|
Ah, thanks for the heads up. Mind doing a follow up with the Changelog change? We'll get used to this flow eventually... |
|
Sorry, my mistake! Now I know. On July 25, 2015 6:24:12 PM EDT, Alice [email protected] wrote:
|
Added changes from #189 to changelog
Formerly known as matchesSelector(), with many vendor prefixes as seen in this function.
I'm using ADT in a jsdom environment, which doesn't support any vendor-prefixed variations
of this function.
http://caniuse.com/#feat=matchesselector