#149 Be able to evaluate page with iframes

dist/js/axs_testing.js

@@ -1545,7 +1545,7 @@ axs.AuditRule.collectMatchingElements = function(a, b, c, d) {
         for (e = f.getDistributedNodes(), f = 0;f < e.length;f++) {
           axs.AuditRule.collectMatchingElements(e[f], b, c, d);
         }
-      } else {
+    } else {
         console.warn("ShadowRoot not provided for", e);
       }
     }
@@ -1590,7 +1590,7 @@ axs.AuditRules = {};
     }
     if (c.name in a) {
       throw Error('Can not add audit rule with same name: "' + c.name + '"');
-    }
+  }
     a[c.name] = b[c.code] = c;
   };
   axs.AuditRules.getRule = function(c) {
@@ -1803,7 +1803,7 @@ axs.AuditRules.addRule({name:"audioWithoutControls", heading:"Audio elements sho
       if (a.test(e) && (e = e.replace(a, ""), !axs.constants.ARIA_PROPERTIES.hasOwnProperty(e))) {
         return !0;
       }
-    }
+  }
     return !1;
   }, code:"AX_ARIA_11"});
 })();

src/audits/FocusableElementNotVisibleAndNotAriaHidden.js

@@ -42,7 +42,8 @@ axs.AuditRules.addRule({
         }
         // Ignore elements which have a negative tabindex and no text content,
         // as they will be skipped by assistive technology
-        if (axs.properties.findTextAlternatives(element, {}).trim() === '')
+        var alternative = axs.properties.findTextAlternatives(element, {});
+        if (alternative == null || alternative.trim() === '')
             return false;
 
         return true;

src/js/AuditRule.js

@@ -182,6 +182,14 @@ axs.AuditRule.collectMatchingElements = function(node, matcher, collection,
             }
         }
     }
+
+    //If it is a iframe, get the contentDocument
+    if (element && element.localName == 'iframe' && element.contentDocument) {
+        axs.AuditRule.collectMatchingElements(element.contentDocument,
+                                              matcher,
+                                              collection,
+                                              opt_shadowRoot);
+    }
     // If it is neither the parent of a ShadowRoot, a <content> element, nor
     // a <shadow> element recurse normally.
     var child = node.firstChild;

test/js/audit-rule-test.js

@@ -41,6 +41,16 @@
         equal(matched.length, DIV_COUNT);
     });
 
+    test("Iframe with simple DOM", function () {
+        var ifrm = document.createElement("IFRAME");
+        var container = document.getElementById('qunit-fixture');
+        container.appendChild(ifrm);
+        ifrm.contentDocument.body.appendChild(buildTestDom());
+        var matched = [];
+        axs.AuditRule.collectMatchingElements(container, matcher, matched);
+        equal(matched.length, DIV_COUNT);
+    });
+
     test("With shadow DOM with no content insertion point", function () {
         var container = document.getElementById('qunit-fixture');
         container.appendChild(buildTestDom());

tools/runner/audit.js

@@ -16,6 +16,9 @@ var page = require('webpage').create(),
     system = require('system'),
     url;
 
+// disabling so we can get the document root from iframes (http -> https)
+page.settings.webSecurityEnabled = false;
+
 if (system.args.length !== 2) {
   console.log('Usage: phantomjs audit.js URL');
   phantom.exit();