if aria-value/now/min/max is a decimal value, warning "ARIA state and property values must be valid"

[akhoury]

According to the spec, a decimal value is fine. What am I missing?

http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow

The value of aria-valuenow is a decimal number. If the range is a set of numeric values, then aria-valuenow is one of those values. For example, if the range is [0, 1], a valid aria-valuenow is 0.5. A value outside the range, such as -2.5 or 1.1, is invalid.

aria-valuenow and aria-valuemax warnings

aria-valuemin warning

Thank you!

[akhoury]

is there a reason why both integer and 'decimal` values are validated the same way?

commit: 2c4f4d0#diff-31cb7b83c1e24f0b5f5b7ebe786bb577R988

src snapshot:

accessibility-developer-tools/src/js/AccessibilityUtils.js

Lines 692 to 707 in 48b283e

	case "integer":
	case "decimal":
	var validNumber = axs.utils.isValidNumber(value);
	if (!validNumber.valid) {
	result.valid = false;
	result.reason = validNumber.reason;
	return result;
	}
	if (Math.floor(validNumber.value) != validNumber.value) {
	result.valid = false;
	result.reason = '' + value + ' is not a whole integer';
	} else {
	result.valid = true;
	result.value = validNumber.value;
	}
	return result;

    case "integer":
    case "decimal":
        var validNumber = axs.utils.isValidNumber(value);
        if (!validNumber.valid) {
            result.valid = false;
            result.reason = validNumber.reason;
            return result;
        }
        if (Math.floor(validNumber.value) != validNumber.value) { // <--- this is testing decimals as well
            result.valid = false;
            result.reason = '' + value + ' is not a whole integer';
        } else {
            result.valid = true;
            result.value = validNumber.value;
        }
        return result;

Looks like an easy fix

[ricksbrown]

Looks like the intention was to fall through from number to decimal not integer to decimal.

[ricksbrown]

PR #196 will fix this.

[ricksbrown]

Closed by #196