Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

False positive AX_FOCUS_01 when control is inside shadow root. #171

Closed
dzhioev opened this issue Jun 17, 2015 · 2 comments
Closed

False positive AX_FOCUS_01 when control is inside shadow root. #171

dzhioev opened this issue Jun 17, 2015 · 2 comments

Comments

@dzhioev
Copy link

dzhioev commented Jun 17, 2015

Here is a repro page: http://dzhioev.net:8080/shadow_focusable_obscured.html
My browser: Google Chrome 45.0.2427.7 (Official Build) dev

Audit thinks that <button> is obscured by <x-foo>, which is not true. Actually <button> is inside <x-foo>'s shadow root.
Looks like patch master...dzhioev:patch-1 solves the issue.

@alice
Copy link
Contributor

alice commented Jun 23, 2015

Thanks for looking into this! Would you be interested in making a PR for that change?

If so, could you please add a test for the issue (presumably based on that repro page)? If you'd rather not, would it be ok if I pulled that change into my own repo to create a PR?

@dzhioev
Copy link
Author

dzhioev commented Jun 23, 2015

Sorry, I don't have time for that. Also I'm not sure that my patch is good enough (maybe axs.utils.parentElement should be used instead of node.parentNode || node.host, don't know). You can use my patch and repro page, if you want to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants