Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show modal with human-readable diff when "Preview Changes" is clicked. #1276

Closed
jonstout opened this issue Jun 16, 2021 · 2 comments
Closed

Show modal with human-readable diff when "Preview Changes" is clicked. #1276

jonstout opened this issue Jun 16, 2021 · 2 comments
Assignees
@jonstout
Labels
Frontend

Comments

@jonstout
Copy link
Member

No description provided.

@jonstout
Copy link
Member Author

Modal should display two buttons:

  • Approve Changes
  • Cancel

If diff has already been approved, the Approve Changes button should be disabled and text changed to Approved.

@jonstout jonstout assigned jonstout and unassigned bensiefers Dec 15, 2021
@jonstout
Copy link
Member Author

  • create modal to hold DiffApprovalForm component
  • update getDiff in nodes.js to get diff text via node.cgi

@jonstout jonstout mentioned this issue Dec 23, 2021
Closed
@jonstout jonstout closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonstout jonstout

Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonstout @bensiefers