Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated "Beautify: Beautify Editor" command #332

Closed
BlaM opened this issue May 7, 2015 · 2 comments
Closed

Remove deprecated "Beautify: Beautify Editor" command #332

BlaM opened this issue May 7, 2015 · 2 comments
Assignees
Milestone

Comments

@BlaM
Copy link

BlaM commented May 7, 2015

"Beautify: Beautify Editor" still shows on the command palette, but when selected displays a message:

The command "beautify:beautify-editor" has been 
removed and changed to "atom-beautify:beautify-editor".

I kind of see the reason for the message to be there, but that also means that if I enter the command palette, type "beau" and press enter I get the message and not a beautified source code. So then I have to press ESC, enter the command palette again and type "beau", press cursor down and ENTER.

Can't we get rid of the command palette menu entry if it is invalid now? Or at least signal Atom to somehow prioritize the valid command higher than the old (expired) one? Maybe rename the menu entry to "[REMOVED] Beautify: Beautify Editor" or something similar?

@Glavin001
Copy link
Owner

Or at least signal Atom to somehow prioritize the valid command higher than the old (expired) one?

Atom uses https://github.com/atom/fuzzaldrin for ordering. Last time I had a command that I wanted the order to be different (later), I had to make it longer... See #240

Maybe rename the menu entry to "[REMOVED] Beautify: Beautify Editor" or something similar?

I'm not sure how Atom allows for renaming commands. All I have is beautify:beautify-editor and it generates Beautify: Beautify Editor from that. See https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L390-L392

Can't we get rid of the command palette menu entry if it is invalid now?

I really want to. I just do not know what is the best way to notify users that the command has been deprecated without them thinking Atom Beautify is broken.
I support the only users this will concern are those who has setup custom shortcuts for Atom beautify: they would no longer work. However, for those using the existing shortcut or using the command palette, would simply type beau.. and have the new Atom Beautify: Beautify Editor.


Let's remove it 👍.

@Glavin001 Glavin001 changed the title Beautify: Beautify Editor still shows on command palette Remove deprecated "Beautify: Beautify Editor" command May 7, 2015
@Glavin001 Glavin001 added this to the v0.28.0 milestone May 7, 2015
@Glavin001 Glavin001 self-assigned this May 7, 2015
@Glavin001
Copy link
Owner

Published to v0.27.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants