-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(z2m): Add specific features to Lixee Tic device #2141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2141 +/- ##
==========================================
+ Coverage 98.50% 98.52% +0.01%
==========================================
Files 867 867
Lines 14243 14272 +29
==========================================
+ Hits 14030 14061 +31
+ Misses 213 211 -2 ☔ View full report in Codecov by Sentry. |
#2862 Bundle Size — 10.28MiB (+0.24%).4c10bd8(current) vs 2540927 master#2858(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2862 |
Baseline #2858 |
|
---|---|---|
Initial JS | 5.58MiB (+0.44% ) |
5.56MiB |
Initial CSS | 304.68KiB |
304.68KiB |
Cache Invalidation | 54.08% |
54.06% |
Chunks | 51 |
51 |
Assets | 171 |
171 |
Modules | 1495 |
1495 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.84% |
0.84% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 1 change
1 regression
Current #2862 |
Baseline #2858 |
|
---|---|---|
JS | 7.37MiB (+0.33% ) |
7.35MiB |
IMG | 2.48MiB |
2.48MiB |
CSS | 321.47KiB |
321.47KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.62KiB |
17.62KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch William-De71:lixee-tic Project dashboard
Generated by RelativeCI Documentation Report issue
57069ec
to
ecc6dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just one feedback
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!