Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save last calendar view #2121

Merged

Conversation

bertrandda
Copy link
Contributor

@bertrandda bertrandda commented Sep 18, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

I saved last calendar view in local storage. With that on user come back, his favorite view is directly choose

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (1f7617c) to head (0de7638).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14182    14182           
=======================================
  Hits        13967    13967           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Sep 18, 2024

#2735 Bundle Size — 10.19MiB (~+0.01%).

0de7638(current) vs 1f7617c master#2731(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#2735
     Baseline
#2731
No change  Initial JS 5.5MiB 5.5MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 56.68% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.84%(+1.2%) 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2735
     Baseline
#2731
Regression  JS 7.28MiB (+0.01%) 7.28MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch bertrandda:feat/save-calendar-vi...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me! Great work 👏

@Pierre-Gilles Pierre-Gilles merged commit b65b18c into GladysAssistant:master Oct 4, 2024
9 checks passed
@bertrandda bertrandda deleted the feat/save-calendar-view branch October 4, 2024 06:56
cicoub13 pushed a commit to cicoub13/Gladys that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants