sync all donations totals

[CarlosQ96]

Summary by CodeRabbit

• Improvements
  • Enhanced the accuracy of total donation calculations by including matching funds in the sum.
  • Simplified the calculation of project donation values for better performance and reliability.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing the donation tracking and project statistics functionalities. Specifically, the donationService now includes a condition to sum matchingFundPriceUsd from the qfRoundHistory table when calculating totalDonations for a project. Simultaneously, projectService has been streamlined to directly assign the result of sumDonationValueUsd to project.sumDonationValueUsd, removing redundant calculations.

Changes

Files	Change Summary
src/services/donationService.ts	Updated updateTotalDonationsOfProject to include matchingFundPriceUsd from qfRoundHistory table.
src/services/projectService.ts	Simplified updateProjectStatistics by directly using sumDonationValueUsd for project.sumDonationValueUsd.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Project
    participant DonationService
    participant QfRoundHistory

    Note over DonationService: Old Flow
    Project->>DonationService: updateTotalDonationsOfProject(projectId)
    DonationService->>QfRoundHistory: getMatchingFundPriceUsd(projectId)
    QfRoundHistory-->>DonationService: matchingFundPriceUsd
    DonationService-->>Project: totalDonations

    Note over DonationService: New Flow
    Project->>DonationService: updateTotalDonationsOfProject(projectId)
    DonationService->>QfRoundHistory: getMatchingFundPriceUsd(projectId)
    QfRoundHistory-->>DonationService: matchingFundPriceUsd
    DonationService-->>Project: totalDonations (includes matchingFundPriceUsd)

Loading

sequenceDiagram
    participant Project
    participant ProjectService
    participant DonationService

    Note over ProjectService: Old Flow
    Project->>ProjectService: updateProjectStatistics(projectId)
    ProjectService->>DonationService: getQfRoundHistoryMatchingValueUsd(projectId)
    DonationService-->>ProjectService: matchingValueUsd
    ProjectService->>Project: project.sumDonationValueUsd = matchingValueUsd

    Note over ProjectService: New Flow
    Project->>ProjectService: updateProjectStatistics(projectId)
    ProjectService->>DonationService: sumDonationValueUsd(projectId)
    DonationService-->>ProjectService: sumDonationValueUsd
    ProjectService->>Project: project.sumDonationValueUsd = sumDonationValueUsd

Loading

Poem

In code's bright dance, a change so grand,
Donations tallied across the land.
With matching funds now in the mix,
Projects thrive, no need for tricks.
Statistics streamlined, clear and bright,
Our code now shines, a guiding light.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (3)

src/services/projectService.ts (1)

Line range hint 27-27: Consider using template literals for string concatenation to improve readability and maintainability.

- slug = slug + '-' + (projectCount - 1);
+ slug = `${slug}-${projectCount - 1}`;

src/services/donationService.ts (2)

Line range hint 4-5: Consider removing unused imports to clean up the codebase and improve clarity.

- import { getTokenPrices } from '@giveth/monoswap';
- import { Token } from '../entities/token';
- import { getChainvineAdapter, getNotificationAdapter } from '../adapters/adaptersFactory';

Also applies to: 45-46

---

Line range hint 372-372: Avoid using non-null assertions as they can lead to runtime errors if assumptions about non-nullability prove incorrect.

- const powerRound = (await getPowerRound())!.round || 1;
+ const powerRoundResult = await getPowerRound();
+ const powerRound = powerRoundResult ? powerRoundResult.round : 1;

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7554f78 and 8950178.

Files selected for processing (2)

• src/services/donationService.ts (1 hunks)
• src/services/projectService.ts (2 hunks)

Additional Context Used

Biome (4)

src/services/donationService.ts (3)

372-372: Forbidden non-null assertion.

---

4-5: All these imports are only used as types.

---

45-46: Some named imports are only used as types.

src/services/projectService.ts (1)

27-27: Template literals are preferred over string concatenation.

Additional comments not posted (2)

src/services/projectService.ts (1)

56-56: The refactoring of updateProjectStatistics simplifies the donation value aggregation. Good job on enhancing readability and potentially improving performance.

src/services/donationService.ts (1)

194-204: The updated SQL query in updateTotalDonationsOfProject now correctly includes matching funds in the total donations calculation. This should provide a more accurate financial overview for projects.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

src/services/donationService.ts (2)

Line range hint 4-5: Optimize imports by removing unused ones.

- import { Project } from '../entities/project';
- import { Token } from '../entities/token';
- import { Donation, DONATION_STATUS } from '../entities/donation';
- import { TransakOrder } from './transak/order';
- import { logger } from '../utils/logger';
- import {
-   findUserById,
-   findUserByWalletAddress,
- } from '../repositories/userRepository';
- import {
-   errorMessages,
-   i18n,
-   translationErrorMessagesKeys,
- } from '../utils/errorMessages';
- import { findProjectById } from '../repositories/projectRepository';
- import { convertExponentialNumber } from '../utils/utils';
- import { fetchGivHistoricPrice } from './givPriceService';
- import {
-   findDonationById,
-   findStableCoinDonationsWithoutPrice,
- } from '../repositories/donationRepository';
- import {
-   getChainvineAdapter,
-   getNotificationAdapter,
- } from '../adapters/adaptersFactory';
- import { calculateGivbackFactor } from './givbackService';
- import SentryLogger from '../sentryLogger';
- import {
-   getUserDonationStats,
-   updateUserTotalDonated,
-   updateUserTotalReceived,
- } from './userService';
- import {
-   refreshProjectDonationSummaryView,
-   refreshProjectEstimatedMatchingView,
- } from './projectViewsService';
- import { AppDataSource } from '../orm';
- import { getQfRoundHistoriesThatDontHaveRelatedDonations } from '../repositories/qfRoundHistoryRepository';
- import { getPowerRound } from '../repositories/powerRoundRepository';
- import { fetchSafeTransactionHash } from './safeServices';
- import { NETWORKS_IDS_TO_NAME } from '../provider';
- import { getTransactionInfoFromNetwork } from './chains';
- import { getEvmTransactionTimestamp } from './chains/evm/transactionService';
- import { getOrttoPersonAttributes } from '../adapters/notifications/NotificationCenterAdapter';
- import { CustomToken, getTokenPrice } from './priceService';
- import { updateProjectStatistics } from './projectService';

Also applies to: 45-46

---

Line range hint 366-366: Avoid using non-null assertions without checking for nullity.

- const powerRound = (await getPowerRound())?.round || 1;
+ const powerRoundResult = await getPowerRound();
+ const powerRound = powerRoundResult ? powerRoundResult.round : 1;

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8950178 and f3eccca.

Files selected for processing (1)

• src/services/donationService.ts (2 hunks)

Additional Context Used

Biome (3)

src/services/donationService.ts (3)

366-366: Forbidden non-null assertion.

---

4-5: All these imports are only used as types.

---

45-46: Some named imports are only used as types.

Additional comments not posted (1)

src/services/donationService.ts (1)

194-198: Ensure the SQL query is safe from SQL injection.

Verification successful

---

The SQL queries in donationService.ts appear to be parameterized correctly, using placeholders like $1 to prevent SQL injection.

• The UPDATE query uses $1 for the projectId parameter.
• The INSERT query also appears to be structured safely.

No immediate issues with SQL injection vulnerabilities were found in the provided snippets.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify if the SQL query in `updateTotalDonationsOfProject` is parameterized correctly.

# Test: Search for SQL queries in the file and check for parameter usage.
rg --type typescript $'SELECT|UPDATE|INSERT' src/services/donationService.ts

Length of output: 112

---

---

Script:

#!/bin/bash
# Description: Verify if the SQL query in `updateTotalDonationsOfProject` is parameterized correctly.

# Test: Search for SQL queries in the file and check for parameter usage.
rg --type ts $'SELECT|UPDATE|INSERT' src/services/donationService.ts

Length of output: 211

---

---

Script:

#!/bin/bash
# Description: Extract SQL queries from `donationService.ts` and verify parameter usage.

# Extract SQL queries
rg --type ts 'SELECT|UPDATE|INSERT' src/services/donationService.ts -A 5 -B 5

Length of output: 1582