Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ortto External Embedded Webform for Onboarding guide #1548

Closed
divine-comedian opened this issue May 7, 2024 · 14 comments
Closed

Replace ortto External Embedded Webform for Onboarding guide #1548

divine-comedian opened this issue May 7, 2024 · 14 comments
Assignees

Comments

@divine-comedian
Copy link
Collaborator

divine-comedian commented May 7, 2024

Currently we have an Onboarding guide listed on https://giveth.io/onboarding that includes a form for users to input their email to receive onboarding guide series of emails.

image

This webform is using an embedded external script, built by Ortto and uses it's own API key to make updates to our CRM and send emails out. Currently it is causing unpredictable behaviour in our CRM, such as changing the userId of customers in our CRM.

We should not use an external script an instead create the form directly into our website and call our API with explicitly the data and behaviour we want to update our CRM.

We also need to edit the journey that is sending this onboarding guide to look for the new activity that will trigger it.

image

Originally posted by @divine-comedian in #1494 (comment)

@RamRamez
Copy link
Collaborator

RamRamez commented May 7, 2024

Thanks @divine-comedian
do we have and Ortto activity for that? because I can't find it in activities list

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented May 7, 2024

Thanks @divine-comedian do we have and Ortto activity for that? because I can't find it in activities list

Just made it -
image

endpoint

https://api-us.ortto.app/v1/activities/create

body attributes

	"activities": [
		{
			"activity_id": "act:cm:onboarding-form",
			"attributes": {
				"str:cm:email": "example string value",
			},
			"fields": {
				"str::email": "[email protected]"
			},
			

@RamRamez
Copy link
Collaborator

@divine-comedian activity is triggered but I didn't receive any email. Could you check please?
image

@divine-comedian
Copy link
Collaborator Author

Sorry about that @RamRamez - there was no journey connected to the activity - it should work now

image

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 1, 2024

@divine-comedian I tested with three different email addresses but didn't get any email.

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented Jul 1, 2024

@divine-comedian I tested with three different email addresses but didn't get any email.

OMG then I have to turn on each individual email - WHO DESIGNED THIS!!!

It should work now @RamRamez 😅

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 3, 2024

I received email for my gmail but didn't receive any email for my outlook account although Ortto activity has been triggered

image

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 3, 2024

@divine-comedian Journey is not triggered for ramin first

image

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented Jul 3, 2024

@RamRamez - I can see it here in the activity panel, maybe it was a bit slow
image

FYI you can only receive each email ONCE per email address

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 7, 2024

@maryjaf @LatifatAbdullahi Please test and verify

https://staging.giveth.io/onboarding

@RamRamez RamRamez moved this from Code Review/PR to QA in All-Devs Jul 7, 2024
@maryjaf maryjaf self-assigned this Jul 8, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Jul 8, 2024

There is no problem in sending emails.
but it would be good a message is shown when user set an invalid email address

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 8, 2024

@maryjaf We have this error for invalid address
image

@divine-comedian
Copy link
Collaborator Author

There is no problem in sending emails. but it would be good a message is shown when user set an invalid email address

There is only the warning we give when user enters the text in an invalid email format. If I understood you correctly I would consider it out of scope to check if the user entered a real email address into the input box.

@divine-comedian
Copy link
Collaborator Author

@RamRamez - LMK when this passes QA and hits production so I can delete the other source API that's being used on the current production webform

@maryjaf maryjaf moved this from QA to Done in All-Devs Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants