Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userId to all API calls & merge-by #1336

Closed
18 tasks done
divine-comedian opened this issue Feb 18, 2024 · 2 comments
Closed
18 tasks done

Add userId to all API calls & merge-by #1336

divine-comedian opened this issue Feb 18, 2024 · 2 comments
Assignees

Comments

@divine-comedian
Copy link
Collaborator

divine-comedian commented Feb 18, 2024

We need to add the userId from the Giveth back-end to all API calls and change the merge_by field to use this userId instead

I've already defined this in our data source as the default so we no longer need to define the merge_by in our API call bodies

We should also add the user-id to the person fields of the API body ahead of the email field, I think its like this:

"fields": {
				"str:cm:user-id": "7988",	
				"str::email": "[email protected]"
			},

Project Cancelled

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body

Project Unlisted

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body

Project Listed

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body

Project Created

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body

Donation Received

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body

Project Verification

  • send userId field in call
  • add userId to person field in body
  • remove merge_by strategy from body
@RamRamez
Copy link
Collaborator

@divine-comedian What about "verification"?

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented Feb 20, 2024

@divine-comedian What about "verification"?

And Verification too! - added it to the checklist

@maryjaf maryjaf closed this as completed Feb 27, 2024
@RamRamez RamRamez assigned maryjaf and unassigned RamRamez Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants