Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to estimated matching in UI that shows update time (~1 hour) #4274

Open
koday1 opened this issue Jun 12, 2024 · 18 comments
Open

Add note to estimated matching in UI that shows update time (~1 hour) #4274

koday1 opened this issue Jun 12, 2024 · 18 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@koday1
Copy link

koday1 commented Jun 12, 2024

Updating estimated matching after every donation in a QF round requires a lot of resources on the backend. To reduce this load we are shifting to updating the matching every 1 hour instead of after every donation. @RamRamez

Per our discussion on the QF call today, we need to add a note in the UI next to the matching estimates that says "Matching estimates updated every hour" OR add the timestamps of the last update, and prediction for the next update.

For reference, here is how Gitcoin handles it, with specific timestamps:

Gitcoinestimatedmatching.png

@mosaeedi Are you able to help with a design for this note next to estimated matching?

This is related to matching improvements to better represent COCM: #4251

@koday1 koday1 added P1 it's a blocker to other tasks or issues. QF Quadratic Funding Related labels Jun 12, 2024
@koday1 koday1 self-assigned this Jun 12, 2024
@laurenluz
Copy link
Member

I love the way the timestamps are being used here in gitcoin and think it would be great to do that! We should probably put a little note about the timestamps in all the places the user sees estimated matching (or at least most of them, including):

  • project card
  • project single page, matching estimated card
  • project single page, donations tab, qf round tab, estimated matching section
  • donation page
  • donation success page? (i don't remember if we put estimated matching here... I think not)

Also @mosaeedi - keep in mind that we should only show these estimates for current, active QF rounds... not ones that have been completed and have the actual matching shown in qf round tab.

@divine-comedian divine-comedian moved this to New Issues in All-Devs Jun 26, 2024
@mosaeedi
Copy link
Collaborator

mosaeedi commented Jul 3, 2024

1. Project card
For Project card, I suggest we put the timestamp inside the tooltip.
Link to Figma
.
Screenshot 2024-07-02 at 8 39 41 PM


2. Project single page, matching estimated card
Link to Figma
.
Screenshot 2024-07-02 at 8 37 59 PM


3. project single page, donations tab, qf round tab, estimated matching section
Link to Figma
.
Screenshot 2024-07-02 at 8 42 09 PM


4. donation page
Link to Figma
.
Screenshot 2024-07-03 at 5 21 32 PM


  1. donation success page
    We just tell user their donations are eligible or not! I don't think we need to add the timestamp there!

@RamRamez
Copy link
Collaborator

RamRamez commented Jul 3, 2024

For best optimization, we implemented it in way that the update time is dependent on the last donation on the QF round, so if there's no new donation (like in midnight), we won't refresh the estimated matching, but when a new donation is made, refresh estimated matching is called, and there's a debounce time of one hour, so if there are other donations in the meantime, refresh estimated matching won't be called. After one hour, refresh estimated matching will be called on the next donation. So, if there's no new donation, estimated matching is already updated and we've saved our DB processes.

TL;DR
@laurenluz @mosaeedi Is it possible to change the copy to something like "Estimated matching will updated every 60 min"?
because we don't know when exactly the estimated matching will be updated. The only thing we know is that the estimated matching is already updated or it will be updated in less than 60 min.

BTW, @laurenluz I believe we can safely set the estimated matching refresh debounce time to 10 min.

@laurenluz
Copy link
Member

I just chatted w/ @RamRamez about this... so if we can update the estimated matching every 10 min, we can reduce the extra dev work by just adding a hard-coded note saying... Next update: <10 min - wherever it is applicable.

@mosaeedi what do you think?

Also, is there some way we can put that on the project card? this round when I was donating and things were not updated right away, I thought there was a bug because all the matching said 0 even on projects I donated to... I wouldn't have thought to check the tool tip.

And for 2. can we decrease the font size on the update text? it's stealing the show a bit from the numbers.

@koday1
Copy link
Author

koday1 commented Jul 4, 2024

@laurenluz I like that idea, I see no issues with saying "Next update <10 min" and letting the user check back in to see the update.

I also agree w/ adding this directly on the project card instead of the tooltip. I ran into the same issues with my first donations in the GIV-Earth round.

cc @mosaeedi

@RamRamez
Copy link
Collaborator

We need this feature for the next QF round.
cc @laurenluz @mosaeedi

@koday1
Copy link
Author

koday1 commented Aug 6, 2024

Hey @RamRamez @mosaeedi just reviving this issue.

If we will use 10 min as the time for updating estimated matching, can we move forward with creating designs for the notes saying 'Next Update <10 min'? As discussed above, it would be in these 4 places:

  1. Project card
  2. Project page, matching estimate card
  3. Project page, donations tab, qf round tab, estimated matching section (while a round is live)
  4. Donation page

@RamRamez
Copy link
Collaborator

RamRamez commented Aug 6, 2024

@koday1 it's 2min on production now, maybe we can skip this design?

@koday1
Copy link
Author

koday1 commented Aug 7, 2024

@RamRamez Got it - thanks for letting me know. @laurenluz I'm curious what your thoughts are on this - should we still add a note for the user if we're going with a 2 min update time?

@laurenluz
Copy link
Member

let's skip it for now. this will all probably change anyway with the updated estiamted matching.

@divine-comedian
Copy link
Contributor

@laurenluz is this issue still relevant?

@laurenluz
Copy link
Member

yes but only in conjuction with the COCM estimated matching update that carlos worked on. we're blocked by a response from the gitcoin team for now. It could be iceboxed, or just on hold

@laurenluz
Copy link
Member

@mosaeedi can you help me on this issue one more time to update these designs to work with the new changes we made to the donation page? We're working on add this back in now as per #4877

image

@mosaeedi
Copy link
Collaborator

mosaeedi commented Dec 3, 2024

The only difference here is showing the estimated matching in USD? based on your comment I don't see anything changed on the donation page!

@laurenluz
Copy link
Member

@mosaeedi no basically on the "donate" page - you had added the timestamp to the old designs, i.e.:

image

This design was done before we implemented the little tags "donation will be matched" / "$5 makes you eligible for GIVbacks", i.e.

image

So we need to find the right place for the timestamp with this updated QF design - it's a small thing.

@laurenluz laurenluz moved this from New Issues to Design in QF: Quadratic funding Jan 7, 2025
@laurenluz laurenluz assigned mosaeedi and unassigned laurenluz Jan 7, 2025
@divine-comedian divine-comedian removed the P1 it's a blocker to other tasks or issues. label Jan 7, 2025
@mosaeedi
Copy link
Collaborator

mosaeedi commented Jan 9, 2025

Here is the design for showing the estimated matching.
Link to Figma

Here is how it should look:
Screenshot 2025-01-09 at 7 30 22 PM

@yegorgolovnia yegorgolovnia assigned CarlosQ96 and unassigned mosaeedi Jan 15, 2025
@divine-comedian
Copy link
Contributor

@yegorgolovnia @laurenluz

now that the designs are here can you provide a clear description and acceptance criteria for this issue. This will make it easier for the devs to estimate and begin work on this issue

@divine-comedian divine-comedian moved this from Design to Research & Planning in All-Devs Jan 17, 2025
@divine-comedian
Copy link
Contributor

Need to get information and save it to a query in order for front-end to get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Research & Planning
Status: Design
Development

No branches or pull requests

7 participants