Archived QF round summary page & link on the main QF page

[laurenluz]

This is coming from #3674

After a QF round has ended, we want to preserve info about the banner, round dates, stats, projects in the round, etc and give it a unique slug. I think this is already somehow built, @MohammadPCh was working on it.

What we need new is some "homepage" where you can see a list of all archived rounds & their corresponding links.

And, somewhere on the main giveth.io/qf page that links to "See Archived round"... This link should not be super prominant.

Does that cover everything @MohammadPCh ?

@Tosinolawale are you able to help w/ this?

[Tosinolawale]

This is coming from #3674

After a QF round has ended, we want to preserve info about the banner, round dates, stats, projects in the round, etc and give it a unique slug. I think this is already somehow built, @MohammadPCh was working on it.

What we need new is some "homepage" where you can see a list of all archived rounds & their corresponding links.

And, somewhere on the main giveth.io/qf page that links to "See Archived round"... This link should not be super prominant.

Does that cover everything @MohammadPCh ?

@Tosinolawale are you able to help w/ this?

On it

[Tosinolawale]

https://www.figma.com/file/C3HykACu0eNImhAqu0our8/Giveth-projects?type=design&node-id=5314%3A41254&mode=design&t=ytJobwoYBPPwiZWP-1

https://www.figma.com/file/C3HykACu0eNImhAqu0our8/Giveth-projects?type=design&node-id=5506%3A50281&mode=design&t=ytJobwoYBPPwiZWP-1

@laurenluz

[laurenluz]

ok Thanks @Tosinolawale - all set.

The most up-to-date version is in figma:

@MohammadPCh would love your feedback - think this will work ok?

cc @jainkrati

[MohammadPCh]

@laurenluz @Tosinolawale Great design! I have a small suggestion:
Since we have a dedicated page for this at https://giveth.io/qf-archive (maybe it's better to change it to /qf-rounds wdyt?), we can remove the tabs on top.
Additionally, we'll need the backend API for fetching this information.
cc: @jainkrati

[laurenluz]

this is the issue for adding banners to the backend cooresponding to QF rounds: #3665 cc @jainkrati @mohammadranjbarz @MohammadPCh

[laurenluz]

@MohammadPCh I think the tabs are kind of nice... then we could just have giveth.io/qf go to this page, default view showing the active round... and then if you click the archive tab, you get to /qf-archive where it shows you all the past/ended rounds.

[laurenluz]

this will work well if we end up expaning qf to run multiple rounds at once.. because then the active round tab can look similar to the archive tab... but be a homepage for different active rounds.

[maryjaf]

It seems this issue isn't ready for testing and is in a wrong state in the board , am I right? @MohammadPCh

[MohammadPCh]

@maryjaf It's on progress.

[MohammadPCh]

@laurenluz Could you please confirm whether the design meets your requirements? I'm eager to begin working on it.

[laurenluz]

Hey @MohammadPCh! The design looks good, I changed some copy and made a small comment about removing "Default" as sort option.... but aside from that, it's good to go!

[MohammadPCh]

Hey @mohammadranjbarz,

We require this information to be fetched from the backend. Could you please provide it?

We need to retrieve all ended (archived) QF rounds with the following details:

1. Slug
2. Name
3. Matching pool
4. Total donations amount
5. Unique donors
6. Start date
7. End date

Additionally, we need to sort them by the following criteria:

• Matching pool
• Number of unique donors
• Newest
• Oldest

Thank you.

cc: @laurenluz @jainkrati

[jainkrati]

@mohammadranjbarz if your PR has all data, lets merge it else pls assign to @CarlosQ96 to proceed on this

[jainkrati]

@CarlosQ96 pls build on the PR by @mohammadranjbarz linked above.

[jainkrati]

@CarlosQ96 pls guide @RamRamez on remaining fix for this.

[MohammadPCh]

This is the final result:

@laurenluz, should we display the dollar sign next to the "Matching Pool"? I remember that the matching pool may have a different unit.
I attempted to retrieve the allocatedTokenSymbol from the backend, but this query doesn't support it.
cc: @jainkrati @RamRamez

[RamRamez]

@MohammadPCh I added allocatedFundUSD and allocatedTokenSymbol to the query:

  query (
   $limit: Int
   $skip: Int
   $orderBy: QfArchivedRoundsOrderBy
  ) {
    qfArchivedRounds(
      limit: $limit
      skip: $skip
      orderBy: $orderBy
    ) {
      id
      name
      slug
      isActive
      allocatedFund
      allocatedFundUSD
      allocatedTokenSymbol
      eligibleNetworks
      beginDate
      endDate
      totalDonations
      uniqueDonors
    }
  }

[RamRamez]

@laurenluz you can fill the allocatedFundUSD and allocatedTokenSymbol fields for all archived QF rounds from AdminJS. If you like to show USD value of allocated fund for archived QF rounds, you can fill only allocatedFundUSD and if you want to show the token amount allocated, you can only fill allocatedTokenSymbol field.

[MohammadPCh]

@RamRamez Thanks

[laurenluz]

@maryjaf - when you test this, can you also check to make sure that things look right and make sense when there is NO active QF round?

We should basically have some simple "there is no active round" and the regular, quadratic funnding generic banner in this case.

related: #4171

[maryjaf]

• 1-Should the mid page QF banner be shown in the page of archived QF? @laurenluz
  

• 2-"Load more" button isn't shown and all of archived qf round in stg aren't shown in this page

• 3- I see some kind of irregularity in the columns of this table, do you think the same?
  @MohammadPCh
  STG:
  
  PRODUCTION
  

[maryjaf]

@maryjaf - when you test this, can you also check to make sure that things look right and make sense when there is NO active QF round?

We should basically have some simple "there is no active round" and the regular, quadratic funnding generic banner in this case.

There are lots of archive rounds on stg and I think removing all of them from db is the only way and isn't a good idea because we need this data in our test
@MohammadPCh Have you implemented a design for this case ? and do you think it could be able to tested ?

[laurenluz]

I sent @MohammadPCh updated copy for the mid-page banner text:

Archived QF Rounds
Explore past quadratic funding rounds on Giveth! Check out the projects who participated, matching funds, donations and more info on this page.

Re:

There are lots of archive rounds on stg and I think removing all of them from db is the only way and isn't a good idea because we need this data in our test
@MohammadPCh Have you implemented a design for this case ? and do you think it could be able to tested ?

Maybe there is some confusion? I wasn't suggesting that we remove any archived rounds. Just, when there is not a round that is currently open & live, the "active round" tab... which should be the default for giveth.io/qf...

I think it is not clear & there is not clear design, I will work with @Tosinolawale on it asap.

[laurenluz]

@MohammadPCh can you confirm also where you are getting the value "unique donors"? because this shouldn't be just unique addresses, but should be, effectively:

• donors who had a passport score above the threshold

• donors whose donations were within an active QF round, to a QF project, on an eligible for QF chain

• donors who are not "flagged as sybil for the round" (in our backend, set in admin bro)

• Also we should have some setting in admin bro where we can mark if a round is completed or not... if the round is not complete, the unique donors should say "pending" cc @CarlosQ96

• Finally, can we change the copy "Total Donations" to say just "Donations (USD value)"

[laurenluz]

working on fixing the /qf homepage design & edge cases in here: #4171

[MohammadPCh]

@laurenluz @maryjaf Thanks, guys!
I have updated it.
@laurenluz, regarding the unique donors, I fetched the data from the back-end, so @mohammadranjbarz or @CarlosQ96 can help us with that.
I also made a modification to the table on my own and merge start and end date columns (sorry 😢, but I thought it was necessary):

[maryjaf]

• 2-"Load more" button isn't shown and all of archived qf round in stg aren't shown in this page
• 3- I see some kind of irregularity in the columns of this table, do you think the same?

Thanks @MohammadPCh These 2 items have been resolved.

This item remains @laurenluz @MohammadPCh
[ ] 1-Should the mid page QF banner be shown in the page of archived QF? @laurenluz

[maryjaf]

• Also we should have some setting in admin bro where we can mark if a round is completed or not... if the round is not complete, the unique donors should say "pending" cc @CarlosQ96

@MohammadPCh can you confirm also where you are getting the value "unique donors"? because this shouldn't be just unique addresses, but should be, effectively:

• donors who had a passport score above the threshold
• donors whose donations were within an active QF round, to a QF project, on an eligible for QF chain
• donors who are not "flagged as sybil for the round" (in our backend, set in admin bro)
• Also we should have some setting in admin bro where we can mark if a round is completed or not... if the round is not complete, the unique donors should say "pending" cc @CarlosQ96

I move it back to inprogress to be checked @CarlosQ96 @mohammadranjbarz

[laurenluz]

re: mid-page banner

in this issue #4171 I put the copy for the banner assuming it exists! but if we want to remove it, it's also ok with me. whatever is the least work 😅

re: "unique donors" number

@CarlosQ96 told me that this number is just the number of unique addresses that donated in the round. it is not considering passport score or flagged sybils or other information. I think, to not further block this issue... we can leave it as-is.

I'll create a new issue for making a new type of "unique donor" variable for each round in our backend, and once we get to building that, we can update this here... but for now, I think this doesn't need to be a blocker and we can just move forward with the simple "unique donors aka unique addresses who donated in the round" thing.

[laurenluz]

@maryjaf if we exclude those edge cases/improvements, is this issue all ok then?

[maryjaf]

• 1-Should the mid page QF banner be shown in the page of archived QF? @laurenluz
• @maryjaf if we exclude those edge cases/improvements, is this issue all ok then?

Yeah, all open problems have been fixed, but we have one question about "mid page QF banner "
Should the mid page QF banner be shown in the page of archived QF? @laurenluz

[laurenluz]

we can remove the mid-page banner

[jainkrati]

@Meriem-BM pls continue on this with guidance from @MohammadPCh

[Meriem-BM]

Hey @maryjaf, the mid banner is removed now

[maryjaf]

Hey @maryjaf, the mid banner is removed now

Thanks, this problem has been fixed